author | herrick |
Mon, 14 Oct 2019 14:36:45 -0400 | |
branch | JDK-8200758-branch |
changeset 58584 | 910b14f4fe3a |
parent 47216 | 71c04702a3d5 |
permissions | -rw-r--r-- |
45572
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
1 |
/* |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
2 |
* Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
4 |
* |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
8 |
* |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
13 |
* accompanied this code). |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
14 |
* |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
18 |
* |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
21 |
* questions. |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
22 |
*/ |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
23 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
24 |
/* |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
25 |
* @test |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
26 |
* @run main/othervm/native -Xcheck:jni StringPlatformChars |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
27 |
*/ |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
28 |
import java.util.Arrays; |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
29 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
30 |
public class StringPlatformChars { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
31 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
32 |
private static final String JNU_ENCODING = System.getProperty("sun.jnu.encoding"); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
33 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
34 |
public static void main(String... args) throws Exception { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
35 |
System.out.println("sun.jnu.encoding: " + JNU_ENCODING); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
36 |
System.loadLibrary("stringPlatformChars"); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
37 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
38 |
// Test varying lengths, provoking different allocation paths |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
39 |
StringBuilder unicodeSb = new StringBuilder(); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
40 |
StringBuilder asciiSb = new StringBuilder(); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
41 |
StringBuilder latinSb = new StringBuilder(); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
42 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
43 |
for (int i = 0; i < 2000; i++) { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
44 |
unicodeSb.append('\uFEFE'); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
45 |
testString(unicodeSb.toString()); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
46 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
47 |
asciiSb.append('x'); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
48 |
testString(asciiSb.toString()); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
49 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
50 |
latinSb.append('\u00FE'); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
51 |
testString(latinSb.toString()); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
52 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
53 |
testString(latinSb.toString() + asciiSb.toString() + unicodeSb.toString()); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
54 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
55 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
56 |
// Exhaustively test simple Strings made up of all possible chars: |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
57 |
for (char c = '\u0001'; c < Character.MAX_VALUE; c++) { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
58 |
testString(String.valueOf(c)); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
59 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
60 |
// Special case: \u0000 is treated as end-of-string in the native code, |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
61 |
// so strings with it should be truncated: |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
62 |
if (getBytes("\u0000abcdef").length != 0 || |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
63 |
getBytes("a\u0000bcdef").length != 1) { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
64 |
System.out.println("Mismatching values for strings including \\u0000"); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
65 |
throw new AssertionError(); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
66 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
67 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
68 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
69 |
private static void testString(String s) throws Exception { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
70 |
byte[] nativeBytes = getBytes(s); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
71 |
byte[] stringBytes = s.getBytes(JNU_ENCODING); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
72 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
73 |
if (!Arrays.equals(nativeBytes, stringBytes)) { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
74 |
System.out.println("Mismatching values for: '" + s + "' " + Arrays.toString(s.chars().toArray())); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
75 |
System.out.println("Native: " + Arrays.toString(nativeBytes)); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
76 |
System.out.println("String: " + Arrays.toString(stringBytes)); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
77 |
throw new AssertionError(s); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
78 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
79 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
80 |
String javaNewS = new String(nativeBytes, JNU_ENCODING); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
81 |
String nativeNewS = newString(nativeBytes); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
82 |
if (!javaNewS.equals(nativeNewS)) { |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
83 |
System.out.println("New string via native doesn't match via java: '" + javaNewS + "' and '" + nativeNewS + "'"); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
84 |
throw new AssertionError(s); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
85 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
86 |
} |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
87 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
88 |
static native byte[] getBytes(String string); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
89 |
|
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
90 |
static native String newString(byte[] bytes); |
07f412070bd9
8181147: JNI_GetStringPlatformChars should have a fast path for UTF-8
redestad
parents:
diff
changeset
|
91 |
} |