src/hotspot/share/gc/g1/g1HotCardCache.cpp
author sjohanss
Tue, 14 Nov 2017 11:33:23 +0100
changeset 47885 5caa1d5f74c1
parent 47634 6a0c42c40cd1
child 51332 c25572739e7c
permissions -rw-r--r--
8186571: Implementation: JEP 307: Parallel Full GC for G1 Summary: Improve G1 worst-case latencies by making the full GC parallel. Reviewed-by: tschatzl, sangheki, ehelin
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     1
/*
46993
dd0f91c85ffc 8186476: Generalize Atomic::add with templates
eosterlund
parents: 46704
diff changeset
     2
 * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     4
 *
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     7
 * published by the Free Software Foundation.
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     8
 *
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    13
 * accompanied this code).
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    14
 *
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    18
 *
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    21
 * questions.
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    22
 *
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    23
 */
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    24
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    25
#include "precompiled.hpp"
30764
fec48bf5a827 8079792: GC directory structure cleanup
pliden
parents: 29203
diff changeset
    26
#include "gc/g1/dirtyCardQueue.hpp"
fec48bf5a827 8079792: GC directory structure cleanup
pliden
parents: 29203
diff changeset
    27
#include "gc/g1/g1CollectedHeap.inline.hpp"
fec48bf5a827 8079792: GC directory structure cleanup
pliden
parents: 29203
diff changeset
    28
#include "gc/g1/g1HotCardCache.hpp"
40655
9f644073d3a0 8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents: 37057
diff changeset
    29
#include "runtime/atomic.hpp"
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    30
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    31
G1HotCardCache::G1HotCardCache(G1CollectedHeap *g1h):
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    32
  _g1h(g1h), _hot_cache(NULL), _use_cache(false), _card_counts(g1h) {}
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    33
26160
aba6b01cb988 8038423: G1: Decommit memory within heap
tschatzl
parents: 25351
diff changeset
    34
void G1HotCardCache::initialize(G1RegionToSpaceMapper* card_counts_storage) {
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    35
  if (default_use_cache()) {
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    36
    _use_cache = true;
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    37
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    38
    _hot_cache_size = (size_t)1 << G1ConcRSLogCacheSize;
46704
211b3f6b75ef 8182169: ArrayAllocator should take MEMFLAGS as regular parameter
kbarrett
parents: 40655
diff changeset
    39
    _hot_cache = ArrayAllocator<jbyte*>::allocate(_hot_cache_size, mtGC);
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    40
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    41
    reset_hot_cache_internal();
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    42
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    43
    // For refining the cards in the hot cache in parallel
27251
7d667f91ec8d 6979279: remove special-case code for ParallelGCThreads==0
mlarsson
parents: 26830
diff changeset
    44
    _hot_cache_par_chunk_size = ClaimChunkSize;
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    45
    _hot_cache_par_claimed_idx = 0;
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    46
26160
aba6b01cb988 8038423: G1: Decommit memory within heap
tschatzl
parents: 25351
diff changeset
    47
    _card_counts.initialize(card_counts_storage);
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    48
  }
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    49
}
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    50
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    51
G1HotCardCache::~G1HotCardCache() {
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    52
  if (default_use_cache()) {
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    53
    assert(_hot_cache != NULL, "Logic");
46704
211b3f6b75ef 8182169: ArrayAllocator should take MEMFLAGS as regular parameter
kbarrett
parents: 40655
diff changeset
    54
    ArrayAllocator<jbyte*>::free(_hot_cache, _hot_cache_size);
29203
5024f7b3322c 8058446: G1 Hot card cache should use ArrayAllocator to allocate the cache array
tschatzl
parents: 28831
diff changeset
    55
    _hot_cache = NULL;
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    56
  }
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    57
}
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    58
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    59
jbyte* G1HotCardCache::insert(jbyte* card_ptr) {
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    60
  uint count = _card_counts.add_card_count(card_ptr);
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    61
  if (!_card_counts.is_hot(count)) {
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    62
    // The card is not hot so do not store it in the cache;
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    63
    // return it for immediate refining.
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    64
    return card_ptr;
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    65
  }
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    66
  // Otherwise, the card is hot.
46993
dd0f91c85ffc 8186476: Generalize Atomic::add with templates
eosterlund
parents: 46704
diff changeset
    67
  size_t index = Atomic::add(1u, &_hot_cache_idx) - 1;
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    68
  size_t masked_index = index & (_hot_cache_size - 1);
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    69
  jbyte* current_ptr = _hot_cache[masked_index];
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    70
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    71
  // Try to store the new card pointer into the cache. Compare-and-swap to guard
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    72
  // against the unlikely event of a race resulting in another card pointer to
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    73
  // have already been written to the cache. In this case we will return
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    74
  // card_ptr in favor of the other option, which would be starting over. This
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    75
  // should be OK since card_ptr will likely be the older card already when/if
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    76
  // this ever happens.
47634
6a0c42c40cd1 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents: 47216
diff changeset
    77
  jbyte* previous_ptr = Atomic::cmpxchg(card_ptr,
6a0c42c40cd1 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents: 47216
diff changeset
    78
                                        &_hot_cache[masked_index],
6a0c42c40cd1 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents: 47216
diff changeset
    79
                                        current_ptr);
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    80
  return (previous_ptr == current_ptr) ? previous_ptr : card_ptr;
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    81
}
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    82
33204
b8a3901ac5b3 8069330: Adjustment of concurrent refinement thresholds does not take hot card cache into account
tschatzl
parents: 33105
diff changeset
    83
void G1HotCardCache::drain(CardTableEntryClosure* cl, uint worker_i) {
36374
613f27cc37b9 8150068: Log the main G1 phases at info level
brutisso
parents: 33204
diff changeset
    84
  assert(default_use_cache(), "Drain only necessary if we use the hot card cache.");
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    85
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    86
  assert(_hot_cache != NULL, "Logic");
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    87
  assert(!use_cache(), "cache should be disabled");
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
    88
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    89
  while (_hot_cache_par_claimed_idx < _hot_cache_size) {
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    90
    size_t end_idx = Atomic::add(_hot_cache_par_chunk_size,
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    91
                                 &_hot_cache_par_claimed_idx);
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    92
    size_t start_idx = end_idx - _hot_cache_par_chunk_size;
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    93
    // The current worker has successfully claimed the chunk [start_idx..end_idx)
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    94
    end_idx = MIN2(end_idx, _hot_cache_size);
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    95
    for (size_t i = start_idx; i < end_idx; i++) {
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    96
      jbyte* card_ptr = _hot_cache[i];
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
    97
      if (card_ptr != NULL) {
33204
b8a3901ac5b3 8069330: Adjustment of concurrent refinement thresholds does not take hot card cache into account
tschatzl
parents: 33105
diff changeset
    98
        bool result = cl->do_card_ptr(card_ptr, worker_i);
b8a3901ac5b3 8069330: Adjustment of concurrent refinement thresholds does not take hot card cache into account
tschatzl
parents: 33105
diff changeset
    99
        assert(result, "Closure should always return true");
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
   100
      } else {
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
   101
        break;
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   102
      }
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   103
    }
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   104
  }
28831
454224c7e3ba 8069273: Decrease Hot Card Cache Lock contention
redestad
parents: 27880
diff changeset
   105
17327
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   106
  // The existing entries in the hot card cache, which were just refined
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   107
  // above, are discarded prior to re-enabling the cache near the end of the GC.
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   108
}
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   109
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   110
void G1HotCardCache::reset_card_counts(HeapRegion* hr) {
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   111
  _card_counts.clear_region(hr);
4bd0581aa231 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
diff changeset
   112
}