hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/cmsLockVerifier.cpp
author ysr
Thu, 14 Aug 2008 17:58:35 -0700
changeset 991 5b25d0a7116f
parent 1 489c9b5090e2
child 4574 b2d5b0975515
permissions -rw-r--r--
6722112: CMS: Incorrect encoding of overflown object arrays during concurrent precleaning Summary: When an object array overflows during precleaning, we should have been marking the entire array dirty, not just its first card. Reviewed-by: jmasa, poonam, tonyp
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
489c9b5090e2 Initial load
duke
parents:
diff changeset
     2
 * Copyright 2002-2005 Sun Microsystems, Inc.  All Rights Reserved.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    19
 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    20
 * CA 95054 USA or visit www.sun.com if you need additional information or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    21
 * have any questions.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
489c9b5090e2 Initial load
duke
parents:
diff changeset
    25
# include "incls/_precompiled.incl"
489c9b5090e2 Initial load
duke
parents:
diff changeset
    26
# include "incls/_cmsLockVerifier.cpp.incl"
489c9b5090e2 Initial load
duke
parents:
diff changeset
    27
489c9b5090e2 Initial load
duke
parents:
diff changeset
    28
///////////// Locking verification specific to CMS //////////////
489c9b5090e2 Initial load
duke
parents:
diff changeset
    29
// Much like "assert_lock_strong()", except that it relaxes the
489c9b5090e2 Initial load
duke
parents:
diff changeset
    30
// assertion somewhat for the parallel GC case, where VM thread
489c9b5090e2 Initial load
duke
parents:
diff changeset
    31
// or the CMS thread might hold the lock on behalf of the parallel
489c9b5090e2 Initial load
duke
parents:
diff changeset
    32
// threads. The second argument is in support of an extra locking
489c9b5090e2 Initial load
duke
parents:
diff changeset
    33
// check for CFL spaces' free list locks.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    34
#ifndef PRODUCT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    35
void CMSLockVerifier::assert_locked(const Mutex* lock, const Mutex* p_lock) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    36
  if (!Universe::is_fully_initialized()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    37
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    38
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    39
489c9b5090e2 Initial load
duke
parents:
diff changeset
    40
  Thread* myThread = Thread::current();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    41
489c9b5090e2 Initial load
duke
parents:
diff changeset
    42
  if (lock == NULL) { // a "lock-free" structure, e.g. MUT, protected by CMS token
489c9b5090e2 Initial load
duke
parents:
diff changeset
    43
    assert(p_lock == NULL, "Unexpected state");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    44
    if (myThread->is_ConcurrentGC_thread()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    45
      // This test might have to change in the future, if there can be
489c9b5090e2 Initial load
duke
parents:
diff changeset
    46
      // multiple peer CMS threads.  But for now, if we're testing the CMS
489c9b5090e2 Initial load
duke
parents:
diff changeset
    47
      assert(myThread == ConcurrentMarkSweepThread::cmst(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    48
             "In CMS, CMS thread is the only Conc GC thread.");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    49
      assert(ConcurrentMarkSweepThread::cms_thread_has_cms_token(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    50
             "CMS thread should have CMS token");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    51
    } else if (myThread->is_VM_thread()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    52
      assert(ConcurrentMarkSweepThread::vm_thread_has_cms_token(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    53
             "VM thread should have CMS token");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    54
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    55
      // Token should be held on our behalf by one of the other
489c9b5090e2 Initial load
duke
parents:
diff changeset
    56
      // of CMS or VM thread; not enough easily testable
489c9b5090e2 Initial load
duke
parents:
diff changeset
    57
      // state info to test which here.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    58
      assert(myThread->is_GC_task_thread(), "Unexpected thread type");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    59
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    60
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    61
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    62
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
  if (ParallelGCThreads == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    64
    assert_lock_strong(lock);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    65
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
    if (myThread->is_VM_thread()
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
        || myThread->is_ConcurrentGC_thread()
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
        || myThread->is_Java_thread()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
      // Make sure that we are holding the associated lock.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
      assert_lock_strong(lock);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
      // The checking of p_lock is a spl case for CFLS' free list
489c9b5090e2 Initial load
duke
parents:
diff changeset
    72
      // locks: we make sure that none of the parallel GC work gang
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
      // threads are holding "sub-locks" of freeListLock(). We check only
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
      // the parDictionaryAllocLock because the others are too numerous.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
      // This spl case code is somewhat ugly and any improvements
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
      // are welcome XXX FIX ME!!
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
      if (p_lock != NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
        assert(!p_lock->is_locked() || p_lock->owned_by_self(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
               "Possible race between this and parallel GC threads");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    80
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
    } else if (myThread->is_GC_task_thread()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
      // Make sure that the VM or CMS thread holds lock on our behalf
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
      // XXX If there were a concept of a gang_master for a (set of)
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
      // gang_workers, we could have used the identity of that thread
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
      // for checking ownership here; for now we just disjunct.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
      assert(lock->owner() == VMThread::vm_thread() ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
             lock->owner() == ConcurrentMarkSweepThread::cmst(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
             "Should be locked by VM thread or CMS thread on my behalf");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    90
      // Make sure we didn't miss some obscure corner case
489c9b5090e2 Initial load
duke
parents:
diff changeset
    91
      ShouldNotReachHere();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    92
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    93
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    94
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    95
#endif