author | stefank |
Fri, 14 Feb 2014 09:29:56 +0100 | |
changeset 22883 | 5378704451dc |
parent 22775 | 52bc5222f5f1 |
child 22876 | 57aa8995d43b |
permissions | -rw-r--r-- |
1 | 1 |
/* |
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
2 |
* Copyright (c) 2000, 2013, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4461
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4461
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4461
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
26 |
#include "memory/allocation.inline.hpp" |
|
27 |
#include "memory/cardTableModRefBS.hpp" |
|
28 |
#include "memory/cardTableRS.hpp" |
|
29 |
#include "memory/sharedHeap.hpp" |
|
30 |
#include "memory/space.hpp" |
|
31 |
#include "memory/space.inline.hpp" |
|
32 |
#include "memory/universe.hpp" |
|
33 |
#include "runtime/java.hpp" |
|
34 |
#include "runtime/mutexLocker.hpp" |
|
35 |
#include "runtime/virtualspace.hpp" |
|
13195 | 36 |
#include "services/memTracker.hpp" |
15482
470d0b0c09f1
8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
jprovino
parents:
13963
diff
changeset
|
37 |
#include "utilities/macros.hpp" |
7397 | 38 |
#ifdef COMPILER1 |
39 |
#include "c1/c1_LIR.hpp" |
|
40 |
#include "c1/c1_LIRGenerator.hpp" |
|
41 |
#endif |
|
42 |
||
1 | 43 |
// This kind of "BarrierSet" allows a "CollectedHeap" to detect and |
44 |
// enumerate ref fields that have been modified (since the last |
|
45 |
// enumeration.) |
|
46 |
||
47 |
size_t CardTableModRefBS::cards_required(size_t covered_words) |
|
48 |
{ |
|
49 |
// Add one for a guard card, used to detect errors. |
|
50 |
const size_t words = align_size_up(covered_words, card_size_in_words); |
|
51 |
return words / card_size_in_words + 1; |
|
52 |
} |
|
53 |
||
54 |
size_t CardTableModRefBS::compute_byte_map_size() |
|
55 |
{ |
|
56 |
assert(_guard_index == cards_required(_whole_heap.word_size()) - 1, |
|
22775 | 57 |
"uninitialized, check declaration order"); |
58 |
assert(_page_size != 0, "uninitialized, check declaration order"); |
|
1 | 59 |
const size_t granularity = os::vm_allocation_granularity(); |
60 |
return align_size_up(_guard_index + 1, MAX2(_page_size, granularity)); |
|
61 |
} |
|
62 |
||
63 |
CardTableModRefBS::CardTableModRefBS(MemRegion whole_heap, |
|
64 |
int max_covered_regions): |
|
65 |
ModRefBarrierSet(max_covered_regions), |
|
66 |
_whole_heap(whole_heap), |
|
67 |
_guard_index(cards_required(whole_heap.word_size()) - 1), |
|
68 |
_last_valid_index(_guard_index - 1), |
|
194 | 69 |
_page_size(os::vm_page_size()), |
1 | 70 |
_byte_map_size(compute_byte_map_size()) |
71 |
{ |
|
72 |
_kind = BarrierSet::CardTableModRef; |
|
73 |
||
74 |
HeapWord* low_bound = _whole_heap.start(); |
|
75 |
HeapWord* high_bound = _whole_heap.end(); |
|
76 |
assert((uintptr_t(low_bound) & (card_size - 1)) == 0, "heap must start at card boundary"); |
|
77 |
assert((uintptr_t(high_bound) & (card_size - 1)) == 0, "heap must end at card boundary"); |
|
78 |
||
79 |
assert(card_size <= 512, "card_size must be less than 512"); // why? |
|
80 |
||
17031 | 81 |
_covered = new MemRegion[max_covered_regions]; |
82 |
_committed = new MemRegion[max_covered_regions]; |
|
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
83 |
if (_covered == NULL || _committed == NULL) { |
1 | 84 |
vm_exit_during_initialization("couldn't alloc card table covered region set."); |
85 |
} |
|
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
86 |
|
17031 | 87 |
_cur_covered_regions = 0; |
1 | 88 |
const size_t rs_align = _page_size == (size_t) os::vm_page_size() ? 0 : |
89 |
MAX2(_page_size, (size_t) os::vm_allocation_granularity()); |
|
90 |
ReservedSpace heap_rs(_byte_map_size, rs_align, false); |
|
13195 | 91 |
|
92 |
MemTracker::record_virtual_memory_type((address)heap_rs.base(), mtGC); |
|
93 |
||
1 | 94 |
os::trace_page_sizes("card table", _guard_index + 1, _guard_index + 1, |
95 |
_page_size, heap_rs.base(), heap_rs.size()); |
|
96 |
if (!heap_rs.is_reserved()) { |
|
97 |
vm_exit_during_initialization("Could not reserve enough space for the " |
|
98 |
"card marking array"); |
|
99 |
} |
|
100 |
||
22551 | 101 |
// The assembler store_check code will do an unsigned shift of the oop, |
1 | 102 |
// then add it to byte_map_base, i.e. |
103 |
// |
|
104 |
// _byte_map = byte_map_base + (uintptr_t(low_bound) >> card_shift) |
|
105 |
_byte_map = (jbyte*) heap_rs.base(); |
|
106 |
byte_map_base = _byte_map - (uintptr_t(low_bound) >> card_shift); |
|
107 |
assert(byte_for(low_bound) == &_byte_map[0], "Checking start of map"); |
|
108 |
assert(byte_for(high_bound-1) <= &_byte_map[_last_valid_index], "Checking end of map"); |
|
109 |
||
110 |
jbyte* guard_card = &_byte_map[_guard_index]; |
|
111 |
uintptr_t guard_page = align_size_down((uintptr_t)guard_card, _page_size); |
|
112 |
_guard_region = MemRegion((HeapWord*)guard_page, _page_size); |
|
18069
e6d4971c8650
8013057: assert(_needs_gc || SafepointSynchronize::is_at_safepoint()) failed: only read at safepoint
dcubed
parents:
17376
diff
changeset
|
113 |
os::commit_memory_or_exit((char*)guard_page, _page_size, _page_size, |
e6d4971c8650
8013057: assert(_needs_gc || SafepointSynchronize::is_at_safepoint()) failed: only read at safepoint
dcubed
parents:
17376
diff
changeset
|
114 |
!ExecMem, "card table last card"); |
1 | 115 |
*guard_card = last_card; |
116 |
||
117 |
_lowest_non_clean = |
|
13195 | 118 |
NEW_C_HEAP_ARRAY(CardArr, max_covered_regions, mtGC); |
1 | 119 |
_lowest_non_clean_chunk_size = |
13195 | 120 |
NEW_C_HEAP_ARRAY(size_t, max_covered_regions, mtGC); |
1 | 121 |
_lowest_non_clean_base_chunk_index = |
13195 | 122 |
NEW_C_HEAP_ARRAY(uintptr_t, max_covered_regions, mtGC); |
1 | 123 |
_last_LNC_resizing_collection = |
13195 | 124 |
NEW_C_HEAP_ARRAY(int, max_covered_regions, mtGC); |
1 | 125 |
if (_lowest_non_clean == NULL |
126 |
|| _lowest_non_clean_chunk_size == NULL |
|
127 |
|| _lowest_non_clean_base_chunk_index == NULL |
|
128 |
|| _last_LNC_resizing_collection == NULL) |
|
129 |
vm_exit_during_initialization("couldn't allocate an LNC array."); |
|
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
130 |
for (int i = 0; i < max_covered_regions; i++) { |
1 | 131 |
_lowest_non_clean[i] = NULL; |
132 |
_lowest_non_clean_chunk_size[i] = 0; |
|
133 |
_last_LNC_resizing_collection[i] = -1; |
|
134 |
} |
|
135 |
||
136 |
if (TraceCardTableModRefBS) { |
|
137 |
gclog_or_tty->print_cr("CardTableModRefBS::CardTableModRefBS: "); |
|
138 |
gclog_or_tty->print_cr(" " |
|
139 |
" &_byte_map[0]: " INTPTR_FORMAT |
|
140 |
" &_byte_map[_last_valid_index]: " INTPTR_FORMAT, |
|
141 |
&_byte_map[0], |
|
142 |
&_byte_map[_last_valid_index]); |
|
143 |
gclog_or_tty->print_cr(" " |
|
144 |
" byte_map_base: " INTPTR_FORMAT, |
|
145 |
byte_map_base); |
|
146 |
} |
|
147 |
} |
|
148 |
||
17376
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
149 |
CardTableModRefBS::~CardTableModRefBS() { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
150 |
if (_covered) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
151 |
delete[] _covered; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
152 |
_covered = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
153 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
154 |
if (_committed) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
155 |
delete[] _committed; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
156 |
_committed = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
157 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
158 |
if (_lowest_non_clean) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
159 |
FREE_C_HEAP_ARRAY(CardArr, _lowest_non_clean, mtGC); |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
160 |
_lowest_non_clean = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
161 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
162 |
if (_lowest_non_clean_chunk_size) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
163 |
FREE_C_HEAP_ARRAY(size_t, _lowest_non_clean_chunk_size, mtGC); |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
164 |
_lowest_non_clean_chunk_size = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
165 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
166 |
if (_lowest_non_clean_base_chunk_index) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
167 |
FREE_C_HEAP_ARRAY(uintptr_t, _lowest_non_clean_base_chunk_index, mtGC); |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
168 |
_lowest_non_clean_base_chunk_index = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
169 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
170 |
if (_last_LNC_resizing_collection) { |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
171 |
FREE_C_HEAP_ARRAY(int, _last_LNC_resizing_collection, mtGC); |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
172 |
_last_LNC_resizing_collection = NULL; |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
173 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
174 |
} |
4ee999c3c007
8012902: remove use of global operator new - take 2
minqi
parents:
17087
diff
changeset
|
175 |
|
1 | 176 |
int CardTableModRefBS::find_covering_region_by_base(HeapWord* base) { |
177 |
int i; |
|
178 |
for (i = 0; i < _cur_covered_regions; i++) { |
|
179 |
if (_covered[i].start() == base) return i; |
|
180 |
if (_covered[i].start() > base) break; |
|
181 |
} |
|
182 |
// If we didn't find it, create a new one. |
|
183 |
assert(_cur_covered_regions < _max_covered_regions, |
|
184 |
"too many covered regions"); |
|
185 |
// Move the ones above up, to maintain sorted order. |
|
186 |
for (int j = _cur_covered_regions; j > i; j--) { |
|
187 |
_covered[j] = _covered[j-1]; |
|
188 |
_committed[j] = _committed[j-1]; |
|
189 |
} |
|
190 |
int res = i; |
|
191 |
_cur_covered_regions++; |
|
192 |
_covered[res].set_start(base); |
|
193 |
_covered[res].set_word_size(0); |
|
194 |
jbyte* ct_start = byte_for(base); |
|
195 |
uintptr_t ct_start_aligned = align_size_down((uintptr_t)ct_start, _page_size); |
|
196 |
_committed[res].set_start((HeapWord*)ct_start_aligned); |
|
197 |
_committed[res].set_word_size(0); |
|
198 |
return res; |
|
199 |
} |
|
200 |
||
201 |
int CardTableModRefBS::find_covering_region_containing(HeapWord* addr) { |
|
202 |
for (int i = 0; i < _cur_covered_regions; i++) { |
|
203 |
if (_covered[i].contains(addr)) { |
|
204 |
return i; |
|
205 |
} |
|
206 |
} |
|
207 |
assert(0, "address outside of heap?"); |
|
208 |
return -1; |
|
209 |
} |
|
210 |
||
211 |
HeapWord* CardTableModRefBS::largest_prev_committed_end(int ind) const { |
|
212 |
HeapWord* max_end = NULL; |
|
213 |
for (int j = 0; j < ind; j++) { |
|
214 |
HeapWord* this_end = _committed[j].end(); |
|
215 |
if (this_end > max_end) max_end = this_end; |
|
216 |
} |
|
217 |
return max_end; |
|
218 |
} |
|
219 |
||
220 |
MemRegion CardTableModRefBS::committed_unique_to_self(int self, |
|
221 |
MemRegion mr) const { |
|
222 |
MemRegion result = mr; |
|
223 |
for (int r = 0; r < _cur_covered_regions; r += 1) { |
|
224 |
if (r != self) { |
|
225 |
result = result.minus(_committed[r]); |
|
226 |
} |
|
227 |
} |
|
228 |
// Never include the guard page. |
|
229 |
result = result.minus(_guard_region); |
|
230 |
return result; |
|
231 |
} |
|
232 |
||
233 |
void CardTableModRefBS::resize_covered_region(MemRegion new_region) { |
|
234 |
// We don't change the start of a region, only the end. |
|
235 |
assert(_whole_heap.contains(new_region), |
|
236 |
"attempt to cover area not in reserved area"); |
|
237 |
debug_only(verify_guard();) |
|
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
238 |
// collided is true if the expansion would push into another committed region |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
239 |
debug_only(bool collided = false;) |
179
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
240 |
int const ind = find_covering_region_by_base(new_region.start()); |
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
241 |
MemRegion const old_region = _covered[ind]; |
1 | 242 |
assert(old_region.start() == new_region.start(), "just checking"); |
243 |
if (new_region.word_size() != old_region.word_size()) { |
|
244 |
// Commit new or uncommit old pages, if necessary. |
|
245 |
MemRegion cur_committed = _committed[ind]; |
|
22551 | 246 |
// Extend the end of this _committed region |
1 | 247 |
// to cover the end of any lower _committed regions. |
248 |
// This forms overlapping regions, but never interior regions. |
|
179
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
249 |
HeapWord* const max_prev_end = largest_prev_committed_end(ind); |
1 | 250 |
if (max_prev_end > cur_committed.end()) { |
251 |
cur_committed.set_end(max_prev_end); |
|
252 |
} |
|
253 |
// Align the end up to a page size (starts are already aligned). |
|
179
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
254 |
jbyte* const new_end = byte_after(new_region.last()); |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
255 |
HeapWord* new_end_aligned = |
179
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
256 |
(HeapWord*) align_size_up((uintptr_t)new_end, _page_size); |
1 | 257 |
assert(new_end_aligned >= (HeapWord*) new_end, |
258 |
"align up, but less"); |
|
2107
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
259 |
// Check the other regions (excludes "ind") to ensure that |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
260 |
// the new_end_aligned does not intrude onto the committed |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
261 |
// space of another region. |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
262 |
int ri = 0; |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
263 |
for (ri = 0; ri < _cur_covered_regions; ri++) { |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
264 |
if (ri != ind) { |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
265 |
if (_committed[ri].contains(new_end_aligned)) { |
2107
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
266 |
// The prior check included in the assert |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
267 |
// (new_end_aligned >= _committed[ri].start()) |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
268 |
// is redundant with the "contains" test. |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
269 |
// Any region containing the new end |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
270 |
// should start at or beyond the region found (ind) |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
271 |
// for the new end (committed regions are not expected to |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
272 |
// be proper subsets of other committed regions). |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
273 |
assert(_committed[ri].start() >= _committed[ind].start(), |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
274 |
"New end of committed region is inconsistent"); |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
275 |
new_end_aligned = _committed[ri].start(); |
2107
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
276 |
// new_end_aligned can be equal to the start of its |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
277 |
// committed region (i.e., of "ind") if a second |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
278 |
// region following "ind" also start at the same location |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
279 |
// as "ind". |
338528868274
6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226)
jmasa
parents:
1676
diff
changeset
|
280 |
assert(new_end_aligned >= _committed[ind].start(), |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
281 |
"New end of committed region is before start"); |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
282 |
debug_only(collided = true;) |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
283 |
// Should only collide with 1 region |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
284 |
break; |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
285 |
} |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
286 |
} |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
287 |
} |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
288 |
#ifdef ASSERT |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
289 |
for (++ri; ri < _cur_covered_regions; ri++) { |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
290 |
assert(!_committed[ri].contains(new_end_aligned), |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
291 |
"New end of committed region is in a second committed region"); |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
292 |
} |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
293 |
#endif |
1 | 294 |
// The guard page is always committed and should not be committed over. |
3587
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
295 |
// "guarded" is used for assertion checking below and recalls the fact |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
296 |
// that the would-be end of the new committed region would have |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
297 |
// penetrated the guard page. |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
298 |
HeapWord* new_end_for_commit = new_end_aligned; |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
299 |
|
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
300 |
DEBUG_ONLY(bool guarded = false;) |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
301 |
if (new_end_for_commit > _guard_region.start()) { |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
302 |
new_end_for_commit = _guard_region.start(); |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
303 |
DEBUG_ONLY(guarded = true;) |
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
304 |
} |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
305 |
|
1 | 306 |
if (new_end_for_commit > cur_committed.end()) { |
307 |
// Must commit new pages. |
|
179
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
308 |
MemRegion const new_committed = |
1 | 309 |
MemRegion(cur_committed.end(), new_end_for_commit); |
310 |
||
311 |
assert(!new_committed.is_empty(), "Region should not be empty here"); |
|
18069
e6d4971c8650
8013057: assert(_needs_gc || SafepointSynchronize::is_at_safepoint()) failed: only read at safepoint
dcubed
parents:
17376
diff
changeset
|
312 |
os::commit_memory_or_exit((char*)new_committed.start(), |
e6d4971c8650
8013057: assert(_needs_gc || SafepointSynchronize::is_at_safepoint()) failed: only read at safepoint
dcubed
parents:
17376
diff
changeset
|
313 |
new_committed.byte_size(), _page_size, |
e6d4971c8650
8013057: assert(_needs_gc || SafepointSynchronize::is_at_safepoint()) failed: only read at safepoint
dcubed
parents:
17376
diff
changeset
|
314 |
!ExecMem, "card table expansion"); |
1 | 315 |
// Use new_end_aligned (as opposed to new_end_for_commit) because |
316 |
// the cur_committed region may include the guard region. |
|
317 |
} else if (new_end_aligned < cur_committed.end()) { |
|
318 |
// Must uncommit pages. |
|
179
59e3abf83f72
6624765: Guarantee failure "Unexpected dirty card found"
jmasa
parents:
1
diff
changeset
|
319 |
MemRegion const uncommit_region = |
1 | 320 |
committed_unique_to_self(ind, MemRegion(new_end_aligned, |
321 |
cur_committed.end())); |
|
322 |
if (!uncommit_region.is_empty()) { |
|
5892
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
323 |
// It is not safe to uncommit cards if the boundary between |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
324 |
// the generations is moving. A shrink can uncommit cards |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
325 |
// owned by generation A but being used by generation B. |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
326 |
if (!UseAdaptiveGCBoundary) { |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
327 |
if (!os::uncommit_memory((char*)uncommit_region.start(), |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
328 |
uncommit_region.byte_size())) { |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
329 |
assert(false, "Card table contraction failed"); |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
330 |
// The call failed so don't change the end of the |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
331 |
// committed region. This is better than taking the |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
332 |
// VM down. |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
333 |
new_end_aligned = _committed[ind].end(); |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
334 |
} |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
335 |
} else { |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
336 |
new_end_aligned = _committed[ind].end(); |
1 | 337 |
} |
338 |
} |
|
339 |
} |
|
340 |
// In any case, we can reset the end of the current committed entry. |
|
341 |
_committed[ind].set_end(new_end_aligned); |
|
342 |
||
5892
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
343 |
#ifdef ASSERT |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
344 |
// Check that the last card in the new region is committed according |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
345 |
// to the tables. |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
346 |
bool covered = false; |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
347 |
for (int cr = 0; cr < _cur_covered_regions; cr++) { |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
348 |
if (_committed[cr].contains(new_end - 1)) { |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
349 |
covered = true; |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
350 |
break; |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
351 |
} |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
352 |
} |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
353 |
assert(covered, "Card for end of new region not committed"); |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
354 |
#endif |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
355 |
|
1 | 356 |
// The default of 0 is not necessarily clean cards. |
357 |
jbyte* entry; |
|
358 |
if (old_region.last() < _whole_heap.start()) { |
|
359 |
entry = byte_for(_whole_heap.start()); |
|
360 |
} else { |
|
361 |
entry = byte_after(old_region.last()); |
|
362 |
} |
|
1676
d80e69372634
6653214: MemoryPoolMXBean.setUsageThreshold() does not support large heap sizes.
swamyv
parents:
1388
diff
changeset
|
363 |
assert(index_for(new_region.last()) < _guard_index, |
1 | 364 |
"The guard card will be overwritten"); |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
365 |
// This line commented out cleans the newly expanded region and |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
366 |
// not the aligned up expanded region. |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
367 |
// jbyte* const end = byte_after(new_region.last()); |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
368 |
jbyte* const end = (jbyte*) new_end_for_commit; |
3587
0140e816d000
6843292: "Expect to be beyond new region unless impacting another region" assertion too strong
jmasa
parents:
2154
diff
changeset
|
369 |
assert((end >= byte_after(new_region.last())) || collided || guarded, |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
370 |
"Expect to be beyond new region unless impacting another region"); |
1 | 371 |
// do nothing if we resized downward. |
754
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
372 |
#ifdef ASSERT |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
373 |
for (int ri = 0; ri < _cur_covered_regions; ri++) { |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
374 |
if (ri != ind) { |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
375 |
// The end of the new committed region should not |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
376 |
// be in any existing region unless it matches |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
377 |
// the start of the next region. |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
378 |
assert(!_committed[ri].contains(end) || |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
379 |
(_committed[ri].start() == (HeapWord*) end), |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
380 |
"Overlapping committed regions"); |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
381 |
} |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
382 |
} |
fb9904179b42
6688799: Second fix for Guarantee failure "Unexpected dirty card found"
jmasa
parents:
360
diff
changeset
|
383 |
#endif |
1 | 384 |
if (entry < end) { |
385 |
memset(entry, clean_card, pointer_delta(end, entry, sizeof(jbyte))); |
|
386 |
} |
|
387 |
} |
|
388 |
// In any case, the covered size changes. |
|
389 |
_covered[ind].set_word_size(new_region.word_size()); |
|
390 |
if (TraceCardTableModRefBS) { |
|
391 |
gclog_or_tty->print_cr("CardTableModRefBS::resize_covered_region: "); |
|
392 |
gclog_or_tty->print_cr(" " |
|
393 |
" _covered[%d].start(): " INTPTR_FORMAT |
|
394 |
" _covered[%d].last(): " INTPTR_FORMAT, |
|
395 |
ind, _covered[ind].start(), |
|
396 |
ind, _covered[ind].last()); |
|
397 |
gclog_or_tty->print_cr(" " |
|
398 |
" _committed[%d].start(): " INTPTR_FORMAT |
|
399 |
" _committed[%d].last(): " INTPTR_FORMAT, |
|
400 |
ind, _committed[ind].start(), |
|
401 |
ind, _committed[ind].last()); |
|
402 |
gclog_or_tty->print_cr(" " |
|
403 |
" byte_for(start): " INTPTR_FORMAT |
|
404 |
" byte_for(last): " INTPTR_FORMAT, |
|
405 |
byte_for(_covered[ind].start()), |
|
406 |
byte_for(_covered[ind].last())); |
|
407 |
gclog_or_tty->print_cr(" " |
|
408 |
" addr_for(start): " INTPTR_FORMAT |
|
409 |
" addr_for(last): " INTPTR_FORMAT, |
|
410 |
addr_for((jbyte*) _committed[ind].start()), |
|
411 |
addr_for((jbyte*) _committed[ind].last())); |
|
412 |
} |
|
5892
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
413 |
// Touch the last card of the covered region to show that it |
477b32b9d021
6952853: SIGSEGV with UseAdaptiveGCBoundary on 64b linux running jvm2008
jmasa
parents:
5547
diff
changeset
|
414 |
// is committed (or SEGV). |
18073
f02460441ddc
8014431: cleanup warnings indicated by the -Wunused-value compiler option on linux
ccheung
parents:
18069
diff
changeset
|
415 |
debug_only((void) (*byte_for(_covered[ind].last()));) |
1 | 416 |
debug_only(verify_guard();) |
417 |
} |
|
418 |
||
419 |
// Note that these versions are precise! The scanning code has to handle the |
|
420 |
// fact that the write barrier may be either precise or imprecise. |
|
421 |
||
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
219
diff
changeset
|
422 |
void CardTableModRefBS::write_ref_field_work(void* field, oop newVal) { |
1 | 423 |
inline_write_ref_field(field, newVal); |
424 |
} |
|
425 |
||
2142
032f4652700c
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
2107
diff
changeset
|
426 |
|
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
427 |
void CardTableModRefBS::non_clean_card_iterate_possibly_parallel(Space* sp, |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
428 |
MemRegion mr, |
9624
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
429 |
OopsInGenClosure* cl, |
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
430 |
CardTableRS* ct) { |
1 | 431 |
if (!mr.is_empty()) { |
11174
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
432 |
// Caller (process_strong_roots()) claims that all GC threads |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
433 |
// execute this call. With UseDynamicNumberOfGCThreads now all |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
434 |
// active GC threads execute this call. The number of active GC |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
435 |
// threads needs to be passed to par_non_clean_card_iterate_work() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
436 |
// to get proper partitioning and termination. |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
437 |
// |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
438 |
// This is an example of where n_par_threads() is used instead |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
439 |
// of workers()->active_workers(). n_par_threads can be set to 0 to |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
440 |
// turn off parallelism. For example when this code is called as |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
441 |
// part of verification and SharedHeap::process_strong_roots() is being |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
442 |
// used, then n_par_threads() may have been set to 0. active_workers |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
443 |
// is not overloaded with the meaning that it is a switch to disable |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
444 |
// parallelism and so keeps the meaning of the number of |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
445 |
// active gc workers. If parallelism has not been shut off by |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
446 |
// setting n_par_threads to 0, then n_par_threads should be |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
447 |
// equal to active_workers. When a different mechanism for shutting |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
448 |
// off parallelism is used, then active_workers can be used in |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
449 |
// place of n_par_threads. |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
450 |
// This is an example of a path where n_par_threads is |
22551 | 451 |
// set to 0 to turn off parallelism. |
11174
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
452 |
// [7] CardTableModRefBS::non_clean_card_iterate() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
453 |
// [8] CardTableRS::younger_refs_in_space_iterate() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
454 |
// [9] Generation::younger_refs_in_space_iterate() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
455 |
// [10] OneContigSpaceCardGeneration::younger_refs_iterate() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
456 |
// [11] CompactingPermGenGen::younger_refs_iterate() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
457 |
// [12] CardTableRS::younger_refs_iterate() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
458 |
// [13] SharedHeap::process_strong_roots() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
459 |
// [14] G1CollectedHeap::verify() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
460 |
// [15] Universe::verify() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
461 |
// [16] G1CollectedHeap::do_collection_pause_at_safepoint() |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
462 |
// |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
463 |
int n_threads = SharedHeap::heap()->n_par_threads(); |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
464 |
bool is_par = n_threads > 0; |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
465 |
if (is_par) { |
15482
470d0b0c09f1
8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
jprovino
parents:
13963
diff
changeset
|
466 |
#if INCLUDE_ALL_GCS |
11174
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
467 |
assert(SharedHeap::heap()->n_par_threads() == |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
468 |
SharedHeap::heap()->workers()->active_workers(), "Mismatch"); |
9624
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
469 |
non_clean_card_iterate_parallel_work(sp, mr, cl, ct, n_threads); |
15482
470d0b0c09f1
8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
jprovino
parents:
13963
diff
changeset
|
470 |
#else // INCLUDE_ALL_GCS |
1 | 471 |
fatal("Parallel gc not supported here."); |
15482
470d0b0c09f1
8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
jprovino
parents:
13963
diff
changeset
|
472 |
#endif // INCLUDE_ALL_GCS |
1 | 473 |
} else { |
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
474 |
// We do not call the non_clean_card_iterate_serial() version below because |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
475 |
// we want to clear the cards (which non_clean_card_iterate_serial() does not |
9624
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
476 |
// do for us): clear_cl here does the work of finding contiguous dirty ranges |
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
477 |
// of cards to process and clear. |
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
478 |
|
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
479 |
DirtyCardToOopClosure* dcto_cl = sp->new_dcto_cl(cl, precision(), |
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
480 |
cl->gen_boundary()); |
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
481 |
ClearNoncleanCardWrapper clear_cl(dcto_cl, ct); |
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
482 |
|
c3657c3324ee
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
ysr
parents:
9418
diff
changeset
|
483 |
clear_cl.do_MemRegion(mr); |
1 | 484 |
} |
485 |
} |
|
486 |
} |
|
487 |
||
9336
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
488 |
// The iterator itself is not MT-aware, but |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
489 |
// MT-aware callers and closures can use this to |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
490 |
// accomplish dirty card iteration in parallel. The |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
491 |
// iterator itself does not clear the dirty cards, or |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
492 |
// change their values in any manner. |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
493 |
void CardTableModRefBS::non_clean_card_iterate_serial(MemRegion mr, |
413920193f83
7037276: Unnecessary double traversal of dirty card windows
ysr
parents:
9183
diff
changeset
|
494 |
MemRegionClosure* cl) { |
11174
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
495 |
bool is_par = (SharedHeap::heap()->n_par_threads() > 0); |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
496 |
assert(!is_par || |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
497 |
(SharedHeap::heap()->n_par_threads() == |
fccee5238e70
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
9624
diff
changeset
|
498 |
SharedHeap::heap()->workers()->active_workers()), "Mismatch"); |
1 | 499 |
for (int i = 0; i < _cur_covered_regions; i++) { |
500 |
MemRegion mri = mr.intersection(_covered[i]); |
|
501 |
if (mri.word_size() > 0) { |
|
502 |
jbyte* cur_entry = byte_for(mri.last()); |
|
503 |
jbyte* limit = byte_for(mri.start()); |
|
504 |
while (cur_entry >= limit) { |
|
505 |
jbyte* next_entry = cur_entry - 1; |
|
506 |
if (*cur_entry != clean_card) { |
|
507 |
size_t non_clean_cards = 1; |
|
508 |
// Should the next card be included in this range of dirty cards. |
|
509 |
while (next_entry >= limit && *next_entry != clean_card) { |
|
510 |
non_clean_cards++; |
|
511 |
cur_entry = next_entry; |
|
512 |
next_entry--; |
|
513 |
} |
|
514 |
// The memory region may not be on a card boundary. So that |
|
515 |
// objects beyond the end of the region are not processed, make |
|
516 |
// cur_cards precise with regard to the end of the memory region. |
|
517 |
MemRegion cur_cards(addr_for(cur_entry), |
|
518 |
non_clean_cards * card_size_in_words); |
|
519 |
MemRegion dirty_region = cur_cards.intersection(mri); |
|
520 |
cl->do_MemRegion(dirty_region); |
|
521 |
} |
|
522 |
cur_entry = next_entry; |
|
523 |
} |
|
524 |
} |
|
525 |
} |
|
526 |
} |
|
527 |
||
528 |
void CardTableModRefBS::dirty_MemRegion(MemRegion mr) { |
|
4461
c17c526d36ef
6906727: UseCompressedOops: some card-marking fixes related to object arrays
ysr
parents:
3695
diff
changeset
|
529 |
assert((HeapWord*)align_size_down((uintptr_t)mr.start(), HeapWordSize) == mr.start(), "Unaligned start"); |
c17c526d36ef
6906727: UseCompressedOops: some card-marking fixes related to object arrays
ysr
parents:
3695
diff
changeset
|
530 |
assert((HeapWord*)align_size_up ((uintptr_t)mr.end(), HeapWordSize) == mr.end(), "Unaligned end" ); |
1 | 531 |
jbyte* cur = byte_for(mr.start()); |
532 |
jbyte* last = byte_after(mr.last()); |
|
533 |
while (cur < last) { |
|
534 |
*cur = dirty_card; |
|
535 |
cur++; |
|
536 |
} |
|
537 |
} |
|
538 |
||
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
539 |
void CardTableModRefBS::invalidate(MemRegion mr, bool whole_heap) { |
4461
c17c526d36ef
6906727: UseCompressedOops: some card-marking fixes related to object arrays
ysr
parents:
3695
diff
changeset
|
540 |
assert((HeapWord*)align_size_down((uintptr_t)mr.start(), HeapWordSize) == mr.start(), "Unaligned start"); |
c17c526d36ef
6906727: UseCompressedOops: some card-marking fixes related to object arrays
ysr
parents:
3695
diff
changeset
|
541 |
assert((HeapWord*)align_size_up ((uintptr_t)mr.end(), HeapWordSize) == mr.end(), "Unaligned end" ); |
1 | 542 |
for (int i = 0; i < _cur_covered_regions; i++) { |
543 |
MemRegion mri = mr.intersection(_covered[i]); |
|
544 |
if (!mri.is_empty()) dirty_MemRegion(mri); |
|
545 |
} |
|
546 |
} |
|
547 |
||
548 |
void CardTableModRefBS::clear_MemRegion(MemRegion mr) { |
|
549 |
// Be conservative: only clean cards entirely contained within the |
|
550 |
// region. |
|
551 |
jbyte* cur; |
|
552 |
if (mr.start() == _whole_heap.start()) { |
|
553 |
cur = byte_for(mr.start()); |
|
554 |
} else { |
|
555 |
assert(mr.start() > _whole_heap.start(), "mr is not covered."); |
|
556 |
cur = byte_after(mr.start() - 1); |
|
557 |
} |
|
558 |
jbyte* last = byte_after(mr.last()); |
|
559 |
memset(cur, clean_card, pointer_delta(last, cur, sizeof(jbyte))); |
|
560 |
} |
|
561 |
||
562 |
void CardTableModRefBS::clear(MemRegion mr) { |
|
563 |
for (int i = 0; i < _cur_covered_regions; i++) { |
|
564 |
MemRegion mri = mr.intersection(_covered[i]); |
|
565 |
if (!mri.is_empty()) clear_MemRegion(mri); |
|
566 |
} |
|
567 |
} |
|
568 |
||
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
569 |
void CardTableModRefBS::dirty(MemRegion mr) { |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
570 |
jbyte* first = byte_for(mr.start()); |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
571 |
jbyte* last = byte_after(mr.last()); |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
572 |
memset(first, dirty_card, last-first); |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
573 |
} |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
574 |
|
9183
3d0e0687fe28
7036482: clear argument is redundant and unused in cardtable methods
ysr
parents:
7397
diff
changeset
|
575 |
// Unlike several other card table methods, dirty_card_iterate() |
3d0e0687fe28
7036482: clear argument is redundant and unused in cardtable methods
ysr
parents:
7397
diff
changeset
|
576 |
// iterates over dirty cards ranges in increasing address order. |
1 | 577 |
void CardTableModRefBS::dirty_card_iterate(MemRegion mr, |
578 |
MemRegionClosure* cl) { |
|
579 |
for (int i = 0; i < _cur_covered_regions; i++) { |
|
580 |
MemRegion mri = mr.intersection(_covered[i]); |
|
581 |
if (!mri.is_empty()) { |
|
582 |
jbyte *cur_entry, *next_entry, *limit; |
|
583 |
for (cur_entry = byte_for(mri.start()), limit = byte_for(mri.last()); |
|
584 |
cur_entry <= limit; |
|
585 |
cur_entry = next_entry) { |
|
586 |
next_entry = cur_entry + 1; |
|
587 |
if (*cur_entry == dirty_card) { |
|
588 |
size_t dirty_cards; |
|
589 |
// Accumulate maximal dirty card range, starting at cur_entry |
|
590 |
for (dirty_cards = 1; |
|
591 |
next_entry <= limit && *next_entry == dirty_card; |
|
592 |
dirty_cards++, next_entry++); |
|
593 |
MemRegion cur_cards(addr_for(cur_entry), |
|
594 |
dirty_cards*card_size_in_words); |
|
595 |
cl->do_MemRegion(cur_cards); |
|
596 |
} |
|
597 |
} |
|
598 |
} |
|
599 |
} |
|
600 |
} |
|
601 |
||
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
602 |
MemRegion CardTableModRefBS::dirty_card_range_after_reset(MemRegion mr, |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
603 |
bool reset, |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
604 |
int reset_val) { |
1 | 605 |
for (int i = 0; i < _cur_covered_regions; i++) { |
606 |
MemRegion mri = mr.intersection(_covered[i]); |
|
607 |
if (!mri.is_empty()) { |
|
608 |
jbyte* cur_entry, *next_entry, *limit; |
|
609 |
for (cur_entry = byte_for(mri.start()), limit = byte_for(mri.last()); |
|
610 |
cur_entry <= limit; |
|
611 |
cur_entry = next_entry) { |
|
612 |
next_entry = cur_entry + 1; |
|
613 |
if (*cur_entry == dirty_card) { |
|
614 |
size_t dirty_cards; |
|
615 |
// Accumulate maximal dirty card range, starting at cur_entry |
|
616 |
for (dirty_cards = 1; |
|
617 |
next_entry <= limit && *next_entry == dirty_card; |
|
618 |
dirty_cards++, next_entry++); |
|
619 |
MemRegion cur_cards(addr_for(cur_entry), |
|
620 |
dirty_cards*card_size_in_words); |
|
1374
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
621 |
if (reset) { |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
622 |
for (size_t i = 0; i < dirty_cards; i++) { |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
623 |
cur_entry[i] = reset_val; |
4c24294029a9
6711316: Open source the Garbage-First garbage collector
ysr
parents:
360
diff
changeset
|
624 |
} |
1 | 625 |
} |
626 |
return cur_cards; |
|
627 |
} |
|
628 |
} |
|
629 |
} |
|
630 |
} |
|
631 |
return MemRegion(mr.end(), mr.end()); |
|
632 |
} |
|
633 |
||
634 |
uintx CardTableModRefBS::ct_max_alignment_constraint() { |
|
635 |
return card_size * os::vm_page_size(); |
|
636 |
} |
|
637 |
||
638 |
void CardTableModRefBS::verify_guard() { |
|
639 |
// For product build verification |
|
640 |
guarantee(_byte_map[_guard_index] == last_card, |
|
641 |
"card table guard has been modified"); |
|
642 |
} |
|
643 |
||
644 |
void CardTableModRefBS::verify() { |
|
645 |
verify_guard(); |
|
646 |
} |
|
647 |
||
648 |
#ifndef PRODUCT |
|
9418
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
649 |
void CardTableModRefBS::verify_region(MemRegion mr, |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
650 |
jbyte val, bool val_equals) { |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
651 |
jbyte* start = byte_for(mr.start()); |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
652 |
jbyte* end = byte_for(mr.last()); |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
653 |
bool failures = false; |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
654 |
for (jbyte* curr = start; curr <= end; ++curr) { |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
655 |
jbyte curr_val = *curr; |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
656 |
bool failed = (val_equals) ? (curr_val != val) : (curr_val == val); |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
657 |
if (failed) { |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
658 |
if (!failures) { |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
659 |
tty->cr(); |
15848
a7b244c71903
8008081: Print outs do not have matching arguments
mikael
parents:
15482
diff
changeset
|
660 |
tty->print_cr("== CT verification failed: ["PTR_FORMAT","PTR_FORMAT"]", start, end); |
9418
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
661 |
tty->print_cr("== %sexpecting value: %d", |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
662 |
(val_equals) ? "" : "not ", val); |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
663 |
failures = true; |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
664 |
} |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
665 |
tty->print_cr("== card "PTR_FORMAT" ["PTR_FORMAT","PTR_FORMAT"], " |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
666 |
"val: %d", curr, addr_for(curr), |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
667 |
(HeapWord*) (((size_t) addr_for(curr)) + card_size), |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
668 |
(int) curr_val); |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
669 |
} |
1 | 670 |
} |
9418
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
671 |
guarantee(!failures, "there should not have been any failures"); |
1 | 672 |
} |
3695
421cfcc8843c
6841313: G1: dirty cards of survivor regions in parallel
apetrusenko
parents:
3587
diff
changeset
|
673 |
|
9418
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
674 |
void CardTableModRefBS::verify_not_dirty_region(MemRegion mr) { |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
675 |
verify_region(mr, dirty_card, false /* val_equals */); |
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
676 |
} |
3695
421cfcc8843c
6841313: G1: dirty cards of survivor regions in parallel
apetrusenko
parents:
3587
diff
changeset
|
677 |
|
421cfcc8843c
6841313: G1: dirty cards of survivor regions in parallel
apetrusenko
parents:
3587
diff
changeset
|
678 |
void CardTableModRefBS::verify_dirty_region(MemRegion mr) { |
9418
32a87dd6b746
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
9336
diff
changeset
|
679 |
verify_region(mr, dirty_card, true /* val_equals */); |
3695
421cfcc8843c
6841313: G1: dirty cards of survivor regions in parallel
apetrusenko
parents:
3587
diff
changeset
|
680 |
} |
1 | 681 |
#endif |
682 |
||
12268 | 683 |
void CardTableModRefBS::print_on(outputStream* st) const { |
684 |
st->print_cr("Card table byte_map: [" INTPTR_FORMAT "," INTPTR_FORMAT "] byte_map_base: " INTPTR_FORMAT, |
|
685 |
_byte_map, _byte_map + _byte_map_size, byte_map_base); |
|
686 |
} |
|
687 |
||
1 | 688 |
bool CardTableModRefBSForCTRS::card_will_be_scanned(jbyte cv) { |
689 |
return |
|
690 |
CardTableModRefBS::card_will_be_scanned(cv) || |
|
691 |
_rs->is_prev_nonclean_card_val(cv); |
|
692 |
}; |
|
693 |
||
694 |
bool CardTableModRefBSForCTRS::card_may_have_been_dirty(jbyte cv) { |
|
695 |
return |
|
696 |
cv != clean_card && |
|
697 |
(CardTableModRefBS::card_may_have_been_dirty(cv) || |
|
698 |
CardTableRS::youngergen_may_have_been_dirty(cv)); |
|
699 |
}; |